Skip to content

Add support for providing ingressClassName #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 20, 2022
Merged

Add support for providing ingressClassName #340

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3a7869a
Add support for providing `ingressClassName`
mamercad Dec 18, 2022
a414eed
Merge remote-tracking branch 'upstream/master' into ingressClassName
mamercad Dec 19, 2022
841f7a7
Merge branch 'master' into ingressClassName
cognifloyd Dec 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Changelog

## In Development
* Add support for providing `ingressClassName`. (#336) (by @mamercad)
* Switch to the official `bats` Docker image for e2e tests. (#338)
* Temporary workaround for #311 to use previous bitnami index from: https://github.com/bitnami/charts/issues/10539 (#312 #318) (by @0xhaven)
* Refactor label definitions to be more consistent by building labels and label selectors in partial helper templates. (#299) (by @cognifloyd)
Expand Down
3 changes: 3 additions & 0 deletions templates/ingress.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ metadata:
{{- toYaml .Values.ingress.annotations | nindent 4 }}
{{- end }}
spec:
{{- if .Values.ingress.ingressClassName }}
ingressClassName: {{ .Values.ingress.ingressClassName }}
{{- end }}
rules:
{{- range .Values.ingress.hosts }}
- host: {{ .host }}
Expand Down
1 change: 1 addition & 0 deletions values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,6 +289,7 @@ ingress:
# - secretName: chart-example-tls
# hosts:
# - chart-example.test
# ingressClassName: nginx-ingress

##
## NOTE: there used to be a secrets.st2 section here. These values have moved into st2.* above. Please update your values.
Expand Down