Enable Extra Volumes in Jobs #333
Conversation
pull-request-size
bot
added
the
size/M
|
Good stuff, +1 for the feature. Looks like the tests are failing though and need an update too. |
|
@armab Unit Tests have been fixed can you merge this change? |
tests/unit/jobs_test.yaml
Outdated
| @@ -0,0 +1,47 @@ | |||
| --- | |||
| suite: Custom Annotations | |||
There was a problem hiding this comment.
| suite: Custom Annotations | |
| suite: Extra Volumes |
Could we rename this file to extra_volumes_test.yaml?
Each file tests one feature across all applicable templates. We can add more extra_volumes tests in another PR for all the deployments that use this too.
There was a problem hiding this comment.
Both file and suite name have been updated
values.yaml
Outdated
| # HTTP_PROXY: http://proxy:1234 | ||
| ## These named secrets (managed outside this chart) will be added to envFrom. | ||
| envFromSecrets: [] | ||
| # mount extra volumes on the st2web pod(s) (primarily useful for k8s-provisioned secrets) |
There was a problem hiding this comment.
| # mount extra volumes on the st2web pod(s) (primarily useful for k8s-provisioned secrets) | |
| # mount extra volumes on the jobs pods (primarily useful for k8s-provisioned secrets) |
There was a problem hiding this comment.
Comment should be updated
|
Ooops. @copart-jafloyd is me. I reviewed in the wrong window. Sorry! |
|
Thanks for the reviews @cognifloyd & @copart-jafloyd ! 😸 |
|
@cognifloyd & @copart-jafloyd the changes you have requested have been completed and the tests are passing. |
4 participants
My database connection required me to provide a certificate trust chain to validate the connection.
I am able to set that certificate in the deployments by using the
extra_volumesoptions in the values file.However, the Jobs do not have that option currently available.
This is my attempt to enable the extra_volume support to Jobs.
I have tested the changes in my cluster and validated that the volume mounts worked for my use case.