Adding the ability to service account to accept custom labels #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/S
|
|
cognifloyd
reviewed
Aug 12, 2022
Member
cognifloyd
left a comment
cognifloyd
left a comment
There was a problem hiding this comment.
You only need the &labels... yaml anchors when reusing bits with *labels... so drop that. At a glance I don't see any other issues.
cognifloyd
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is about adding the ability to service-account.yaml template to accept custom labels defined through values.yaml
Closes: #326
Use case:
Internally we have a requirement to have a custom label to the service account (SA) in order to get the SA or the pod associated with SA access to internal vault. In other words, when a SA has a specific label, it would help the corresponding pod to obtain access to vault storage.