Ingress api version deprecation support for k8s v.1.22. fixes #277 #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/S
arms11
force-pushed
the
ingress_api_version_k8s_122_support_issue_277
branch
from
48359f4 to
6877f50
Compare
|
Please add a changelog. And would you mind adding some unit tests for the Ingress? There are examples in tests/unit and see the readme under tests |
|
Thanks @cognifloyd for the feedback. Will take a look tomorrow. |
|
|
pull-request-size
bot
added
size/L
cognifloyd
force-pushed
the
ingress_api_version_k8s_122_support_issue_277
branch
from
b9e886b to
fd61b79
Compare
cognifloyd
force-pushed
the
ingress_api_version_k8s_122_support_issue_277
branch
from
f5a9ad0 to
f168716
Compare
and fix tests
cognifloyd
approved these changes
Jul 9, 2022
cognifloyd
reviewed
Jul 9, 2022
| paths: | ||
| {{- range .paths }} | ||
| - path: {{ default "/*" .path }} | ||
| {{- if $.Capabilities.APIVersions.Has "networking.k8s.io/v1" }} |
There was a problem hiding this comment.
The tests uncovered a bug here. It was missing $ so I added that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ingress.yamluses correctapiVersionand relatedspecchanges that are now required starting versionv1.22ofkubernetes.