Skip to content

Refactor: Add helpers/partials to build labels #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 5, 2022
Merged

Refactor: Add helpers/partials to build labels #299

merged 10 commits into from
Jun 5, 2022

Conversation

@cognifloyd
Copy link
Member

@cognifloyd cognifloyd commented Mar 25, 2022 •
edited
Loading

This does not change any of the existing labels.
The only difference in output is that it adds a couple of labels that were missing from the ServiceAccount.

This is a step towards implementing #273

@pull-request-size pull-request-size bot added the size/XL PR that changes 500-999 lines. Consider splitting work into several ones that easier to review. label Mar 25, 2022
@cognifloyd cognifloyd requested a review from arm4b March 25, 2022 03:50
@cognifloyd cognifloyd self-assigned this Mar 25, 2022
@cognifloyd cognifloyd added this to the prod/GA milestone Mar 25, 2022
@arm4b arm4b modified the milestones: prod/GA, post-GA Apr 21, 2022
@CLAassistant
Copy link

CLAassistant commented May 11, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@cognifloyd
Copy link
Member Author

cognifloyd commented May 17, 2022

@armab why did you move this to post-GA?
I would like to finish #273 (standardize labels) before GA, and this is a pre-requisite to that.

@cognifloyd cognifloyd modified the milestones: post-GA, prod/GA Jun 2, 2022
arm4b
arm4b approved these changes Jun 2, 2022
View reviewed changes
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sorry, I see that I missed this one

arm4b
arm4b reviewed Jun 2, 2022
View reviewed changes
@cognifloyd cognifloyd merged commit ff5df44 into StackStorm:master Jun 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@arm4b arm4b arm4b approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cognifloyd cognifloyd

Labels

Helm size/XL PR that changes 500-999 lines. Consider splitting work into several ones that easier to review.

Projects

None yet

Milestone

prod/GA

Development

Successfully merging this pull request may close these issues.

3 participants

@cognifloyd @CLAassistant @arm4b