Ensure st2.datastore_crypto_key and st2chatop.env values are strings

[cognifloyd]

datastore_crypto_key and st2chatops secrets are both likely to have non-string content.
Examples:

• Using YAML or plain JSON formatting for datastore_crypto_key in values instead of a JSON-encoded string wrapped in single quotes.
• Using an integer for one of the chatops env vars (like ST2_COMMANDS_RELOAD_INTERVAL: 10 instead of ST2_COMMANDS_RELOAD_INTERVAL: "10")

We can easily cast these to string in the secret templates to fix this.

Resolves #229

[cognifloyd]

@armab I would like to include this one in the next release as well.

[arm4b]

I wouldn't add an option for users to shoot themselves in their foot.
Datastore crypto key is an artifact that you generate and copy-paste, instead of trying to split it into pieces or re-format with yaml.

[cognifloyd]

Because I shot myself in the foot. JSON is valid YAML. If you don't surround what you copy/paste with single quotes, it will be parsed into a dictionary and then things break.
This change makes the chart more forgiving.

[arm4b]

Does it also mean https://github.com/StackStorm/stackstorm-ha/blob/3dcd06b772ca5a2f4133a22fa9b382e03b5b422a/values.yaml#L50-L53 had initially wrong instructions?

[cognifloyd]

Yes. This change makes those instructions valid.

[arm4b]

Can we change the Helm values instructions? Similar to what we had for SSH key

datastore_crypto_key: |
  {"hmacKey": {"hmacKeyString": "", "size": 256}, "size": 256, "aesKeyString": "", "mode": "CBC"} 

[cognifloyd]

Sure.
Which part of this change do you dislike? The kindIs "String" check, or passing the value through toJson?

[cognifloyd]

I updated the PR to drop toJson here and update the docs in values.yaml instead.

I would still like to understand your intuition - Why/how does serializing the datastore_crypto_key create "an option for users to shoot themselves in their foot"?

[arm4b]

I think it comes from the expectations that the datastore crypto key is an immutable artifact that users just generate and copy-paste, instead of trying to split it into pieces, re-format, or modify. So it's best to keep that piece of data as is to avoid any further confusion or corner cases.

[arm4b]

this looks good to me

[arm4b]

Thanks a lot!