Refactor: Use helper for st2-config-vol volume/volumeMounts definitions

[cognifloyd]

This reduces duplication of the st2-config-vol definitions in volumes: and volumeMounts: blocks.

[cognifloyd]

pull-request-size bot says that this PR is size/L because it deletes a lot of lines. In templates/deployments.yaml and templates/jobs.yaml I added two lines for every 9 lines I removed:

---
apiVersion: ...
kind: ...
metadata:
  ...
spec:
  template:
    metadata:
      ...
    spec:
      ...
      containers:
      - name: ...
        ...
        volumeMounts:
-       - name: st2-config-vol
-         mountPath: /etc/st2/st2.docker.conf
-         subPath: st2.docker.conf
-       - name: st2-config-vol
-         mountPath: /etc/st2/st2.user.conf
-         subPath: st2.user.conf
+      {{- include "st2-config-volume-mounts" . | nindent 8 }}
      volumes:
-       - name: st2-config-vol
-         configMap:
-           name: {{ .Release.Name }}-st2-config
+      {{- include "st2-config-volume" . | nindent 8 }}

And then the template definition is just:
https://github.com/StackStorm/stackstorm-ha/blob/d330e353ab7a312cb7647c56e0bd441ee10b2509/templates/_helpers.tpl#L74-L87

[ericreeves]

This seems like a great change.

[cognifloyd]

rebased on master

[ericreeves]

This looks great.

[cognifloyd]

rebased on master

[ericreeves]

Some more much needed deduplication!

[cognifloyd]

@armab This one is the next easiest PR to review. Please and thank you!

[arm4b]

LGTM!

[cognifloyd]

Tests are green :)