Skip to content

Conversation

@cognifloyd
Copy link
Member

@cognifloyd cognifloyd commented Jun 14, 2021

If pods do not have imagePullSecrets, they get populated from the ServiceAccount[1]. In our k8s cluster, we prefer defining them on the ServiceAccount so that there are fewer places to update if a change is required.

Effectively, this means we can use serviceAccount.pullSecret instead of image.pullSecret in values.yaml.

[1] From the k8s docs:

  1. If the pod does not contain any imagePullSecrets, then imagePullSecrets of the ServiceAccount are added to the pod.

TODO:

  • PR description
  • changelog entry

@pull-request-size pull-request-size bot added the size/XS PR that changes 0-9 lines. Quick fix/merge. label Jun 14, 2021
@arm4b arm4b added the enhancement New feature or request label Jun 16, 2021
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very helpful, thanks for the contribution! 👍

@arm4b arm4b merged commit 9365247 into StackStorm:master Jun 16, 2021
@cognifloyd cognifloyd deleted the service-account-pull-secrets branch November 11, 2021 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request size/XS PR that changes 0-9 lines. Quick fix/merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants