Add the ability to define imagePullSecrets for service account #196
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If pods do not have imagePullSecrets, they get populated from the ServiceAccount[1]. In our k8s cluster, we prefer defining them on the ServiceAccount so that there are fewer places to update if a change is required.
Effectively, this means we can use
serviceAccount.pullSecretinstead ofimage.pullSecretin values.yaml.[1] From the k8s docs:
TODO: