- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 117
 
Introduced initContainers to wait for DB/MQ availability #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduced initContainers to wait for DB/MQ availability #178
Conversation
| 
           Attempt to resolve #11 . Please review.  | 
    
| 
           Nice! 👍 Any downsides or edge cases anyone can think of?  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, thanks for the contribution 👍
Left first comments on top of my head that need addressing.
We'll definitely need a Changelog for this enhancement.
I also think we may omit wait-for scenario for st2client Pod so it can start without Init.
| 
           Thanks @armab for the feedback. I will make the requested changes.  | 
    
| {{- end -}} | ||
| 
               | 
          ||
| {{- define "init-containers-wait-for-db" -}} | ||
| {{- if index .Values "mongodb" "enabled" }} | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just thought about that edge case. Perfect to have it already codified here 👍
| # Changelog | ||
| 
               | 
          ||
| ## In Development | ||
| * Implemented initContainers to wait for DB/MQ to be available for St2 Pods (#178) | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI I moved this changelog under the In Development section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this stability improvement! 👍
Closes #11
Added initContainers for waiting on DB and MQ dependencies to be formed and connected before proceeding to initialize dependent containers of ST2 services.