Updated k8s_ha documentation for redis as backend coordination #1050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@armab - Please review. Thanks. |
arm4b
suggested changes
Jan 22, 2021
Member
arm4b
left a comment
arm4b
left a comment
There was a problem hiding this comment.
Thanks for updating the st2docs!
A few changes:
-
CI is not happy with the syntax. Provided a pointer in the comment above.
-
Similar to previous Readme.md changes from your PR: arms11/stackstorm-ha@15abe2f there are a few more places where we can replace
etcdwithredis.
Contributor
Author
|
Thanks @armab . Duh...I did not realize there were other references. I replaced them as appropriate. Checked the build also have passed. Please review! |
arm4b
approved these changes
Jan 23, 2021
Member
arm4b
left a comment
arm4b
left a comment
There was a problem hiding this comment.
Looks good!
Thanks for syncing the Documentation, following the StackStorm/stackstorm-k8s#169 change 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to StackStorm/stackstorm-k8s#169