Skip to content

Fix 'st2 key load' that errors when importing an empty file #4393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 16, 2018
Merged

Fix 'st2 key load' that errors when importing an empty file #4393

merged 6 commits into from
Oct 16, 2018

Conversation

@arm4b
Copy link
Member

@arm4b arm4b commented Oct 16, 2018

A small bug, found during the StackStorm/stackstorm-k8s#30 K8s work

Loading K/V from an empty file throws an error and fails with non-zero exit code.

Error

$ touch st2kv.yaml
$ st2 key load st2kv.yaml 
ERROR: 'NoneType' object has no attribute '__getitem__'

$ echo $?
1

Fixed version

$ st2 key load st2kv.yaml 
No matching items found

@arm4b arm4b added this to the 3.0.0 milestone Oct 16, 2018
@arm4b arm4b mentioned this pull request Oct 16, 2018
Merged
@arm4b arm4b added RFR and removed WIP labels Oct 16, 2018
@arm4b arm4b merged commit 53c2982 into master Oct 16, 2018
@arm4b arm4b deleted the fix/kv-load-empty-file branch October 16, 2018 21:51
@cognifloyd cognifloyd removed the RFR label Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kami Kami Kami approved these changes

Assignees

No one assigned

Labels

bug component:st2client

Projects

None yet

Milestone

2.10.0

Development

Successfully merging this pull request may close these issues.

5 participants

@arm4b @Kami @cognifloyd @armab