Clean up setup.py #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arm4b
suggested changes
Mar 18, 2023
.circleci/config.yml
Outdated
Comment on lines
41
to
47
| build_packages: | ||
| <<: *defaults | ||
| docker: | ||
| - image: circleci/python:2.7 | ||
| - image: circleci/python:3.6 | ||
| environment: | ||
| DISTROS: xenial bionic el7 el8 | ||
| DOCKER_DISTROS: xenial bionic centos7 centos8 | ||
| DISTROS: "bionic focal el7 el8" | ||
| DOCKER_DISTROS: bionic focal centos7 rockylinux8 |
There was a problem hiding this comment.
You can remove the build deb/rpm packaging workflow part for this repo.
We're not building them really, also this repo is somewhat open-sourced leftower from the LF transition. Not sure if it works somehow, but it's not part of the release processes.
The only part that makes sense to keep are just the py tests.
There was a problem hiding this comment.
sweet. I like to delete old stuff.
arm4b
approved these changes
Mar 22, 2023
|
This is a lot better. CI is still broken, but less so. I'm merging this, then someone else can work on fixing CI from this point |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop problematic pip version check that can break pants/pex lockfile generation. Also, update python classifiers to 3.6-3.8 and bump the version.
And update circle config to skip python 2.7 and just use 3.6 for now.