Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
dd41412
loosening up some tests
pimguilherme Mar 28, 2022
a823409
removing relay_state_id because that doesn't work with HA
pimguilherme Apr 18, 2022
936506a
working version of the CLI/WEB saml auth :)
pimguilherme Apr 20, 2022
e7f306e
adding very simple rbac
pimguilherme Apr 28, 2022
433b8eb
adjusting error handling and removing unnecessary params
pimguilherme Jul 11, 2022
135781e
removing unnecessary field :)
pimguilherme Jul 11, 2022
a95b2c8
fixing lint errors
pimguilherme Jul 11, 2022
bdae186
removing apparently unnecessary config
pimguilherme Jul 11, 2022
f4491e1
implementing some tests
pimguilherme Jul 12, 2022
969a6a6
adjusting some validation and tests :)
pimguilherme Jul 13, 2022
a08f744
making tests pass! eye :D
pimguilherme Jul 13, 2022
b4884b0
adjusting semantics
pimguilherme Jul 13, 2022
ed7102f
tests almost okay :)
pimguilherme Jul 14, 2022
01eadc9
organizing tests
pimguilherme Jul 14, 2022
44d23af
adding tests for role mapping :)
pimguilherme Jul 14, 2022
713efa6
adjusting lint stuff :)
pimguilherme Jul 19, 2022
55dc427
bumping pysaml version!
pimguilherme Jul 19, 2022
53a8f5c
Squashed 'lint-configs/' changes from 66f9c38..4696bad
pimguilherme Jul 19, 2022
fd946d5
Merge commit '53a8f5c884cefe50ab6a54d7820c26432c2e395d' into feat/saml
pimguilherme Jul 19, 2022
a572648
adjusting lint :)
pimguilherme Jul 19, 2022
d2699cd
implementing custom configuration for pysaml2 client :)
pimguilherme Jul 19, 2022
8b6c25e
removing role-based mapping and using group based instead
pimguilherme Jul 19, 2022
eaa859d
adding generic exception test
pimguilherme Jul 20, 2022
c66546d
minor changes to format
pimguilherme Jul 22, 2022
910ccda
added some details
pimguilherme Nov 11, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ compilepy3:
@echo
@echo "==================== pylint ===================="
@echo
. $(VIRTUALENV_DIR)/bin/activate; pylint -j $(PYLINT_CONCURRENCY) -E --rcfile=./lint-configs/python/.pylintrc --load-plugins=pylint_plugins.api_models --load-plugins=pylint_plugins.db_models st2auth_sso_saml2/
. $(VIRTUALENV_DIR)/bin/activate; pylint -j $(PYLINT_CONCURRENCY) -E --rcfile=./lint-configs/python/.pylintrc st2auth_sso_saml2/
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure this change is actually needed


.PHONY: .unit-tests
.unit-tests:
Expand Down
2 changes: 1 addition & 1 deletion lint-configs/python/.flake8
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
max-line-length = 100
# L102 - apache license header
enable-extensions = L101,L102
ignore = E128,E402,E722,W504
ignore = E128,E402,E722,W504,W503
exclude=*.egg/*,build,dist

# Configuration for flake8-copyright extension
Expand Down
32 changes: 32 additions & 0 deletions lint-configs/python/.pylintrc-exchange
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
[MESSAGES CONTROL]
# C0111 Missing docstring
# I0011 Warning locally suppressed using disable-msg
# I0012 Warning locally suppressed using disable-msg
# W0704 Except doesn't do anything Used when an except clause does nothing but "pass" and there is no "else" clause
# W0142 Used * or * magic* Used when a function or method is called using *args or **kwargs to dispatch arguments.
# W0212 Access to a protected member %s of a client class
# W0232 Class has no __init__ method Used when a class has no __init__ method, neither its parent classes.
# W0613 Unused argument %r Used when a function or method argument is not used.
# W0702 No exception's type specified Used when an except clause doesn't specify exceptions type to catch.
# R0201 Method could be a function
# W0614 Unused import XYZ from wildcard import
# R0914 Too many local variables
# R0912 Too many branches
# R0915 Too many statements
# R0913 Too many arguments
# R0904 Too many public methods
# E0211: Method has no argument
# E1128: Assigning to function call which only returns None Used when an assignment is done on a function call but the inferred function returns nothing but None.
# E1129: Context manager ‘%s’ doesn’t implement __enter__ and __exit__. Used when an instance in a with statement doesn’t implement the context manager protocol(__enter__/__exit__).
disable=C0103,C0111,I0011,I0012,W0704,W0142,W0212,W0232,W0613,W0702,R0201,W0614,R0914,R0912,R0915,R0913,R0904,R0801,not-context-manager,assignment-from-none

[TYPECHECK]
# Note: This modules are manipulated during the runtime so we can't detect all the properties during
# static analysis
# The lib package is automatically added to PYTHONPATH by ST2 for Python actions
ignored-modules=distutils,eventlet.green.subprocess,six,six.moves,lib

[FORMAT]
max-line-length=100
max-module-lines=1000
indent-string=' '
33 changes: 33 additions & 0 deletions lint-configs/python/.pylintrc-pack-ci
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
[MESSAGES CONTROL]
# C0111 Missing docstring
# I0011 Warning locally suppressed using disable-msg
# I0012 Warning locally suppressed using disable-msg
# W0704 Except doesn't do anything Used when an except clause does nothing but "pass" and there is no "else" clause
# W0142 Used * or * magic* Used when a function or method is called using *args or **kwargs to dispatch arguments.
# W0212 Access to a protected member %s of a client class
# W0232 Class has no __init__ method Used when a class has no __init__ method, neither its parent classes.
# W0511 Used when a warning note as FIXME or XXX is detected.
# W0613 Unused argument %r Used when a function or method argument is not used.
# W0702 No exception's type specified Used when an except clause doesn't specify exceptions type to catch.
# R0201 Method could be a function
# W0614 Unused import XYZ from wildcard import
# W0621 Redefining name %r from outer scope (line %s) Used when a variable’s name hide a name defined in the outer scope.
# R0914 Too many local variables
# R0912 Too many branches
# R0915 Too many statements
# R0913 Too many arguments
# R0904 Too many public methods
# E0211: Method has no argument
# E1128: Assigning to function call which only returns None Used when an assignment is done on a function call but the inferred function returns nothing but None.
# E1129: Context manager ‘%s’ doesn’t implement __enter__ and __exit__. Used when an instance in a with statement doesn’t implement the context manager protocol(__enter__/__exit__).
disable=C0103,C0111,I0011,I0012,W0704,W0142,W0212,W0232,W0511,W0613,W0702,R0201,W0614,W0621,R0914,R0912,R0915,R0913,R0904,R0801,not-context-manager,assignment-from-none

[TYPECHECK]
# Note: This modules are manipulated during the runtime so we can't detect all the properties during
# static analysis
ignored-modules=distutils,eventlet.green.subprocess,six,six.moves,st2common

[FORMAT]
max-line-length=100
max-module-lines=1000
indent-string=' '
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
pysaml2>=4.8.0,<4.9.0
pysaml2>=7.1.2,<7.2.0
Loading