-
Notifications
You must be signed in to change notification settings - Fork 5
Implementing SAML integration with st2 #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pimguilherme
wants to merge
25
commits into
StackStorm:master
Choose a base branch
from
pimguilherme:feat/saml
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
dd41412
loosening up some tests
pimguilherme a823409
removing relay_state_id because that doesn't work with HA
pimguilherme 936506a
working version of the CLI/WEB saml auth :)
pimguilherme e7f306e
adding very simple rbac
pimguilherme 433b8eb
adjusting error handling and removing unnecessary params
pimguilherme 135781e
removing unnecessary field :)
pimguilherme a95b2c8
fixing lint errors
pimguilherme bdae186
removing apparently unnecessary config
pimguilherme f4491e1
implementing some tests
pimguilherme 969a6a6
adjusting some validation and tests :)
pimguilherme a08f744
making tests pass! eye :D
pimguilherme b4884b0
adjusting semantics
pimguilherme ed7102f
tests almost okay :)
pimguilherme 01eadc9
organizing tests
pimguilherme 44d23af
adding tests for role mapping :)
pimguilherme 713efa6
adjusting lint stuff :)
pimguilherme 55dc427
bumping pysaml version!
pimguilherme 53a8f5c
Squashed 'lint-configs/' changes from 66f9c38..4696bad
pimguilherme fd946d5
Merge commit '53a8f5c884cefe50ab6a54d7820c26432c2e395d' into feat/saml
pimguilherme a572648
adjusting lint :)
pimguilherme d2699cd
implementing custom configuration for pysaml2 client :)
pimguilherme 8b6c25e
removing role-based mapping and using group based instead
pimguilherme eaa859d
adding generic exception test
pimguilherme c66546d
minor changes to format
pimguilherme 910ccda
added some details
pimguilherme File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| [MESSAGES CONTROL] | ||
| # C0111 Missing docstring | ||
| # I0011 Warning locally suppressed using disable-msg | ||
| # I0012 Warning locally suppressed using disable-msg | ||
| # W0704 Except doesn't do anything Used when an except clause does nothing but "pass" and there is no "else" clause | ||
| # W0142 Used * or * magic* Used when a function or method is called using *args or **kwargs to dispatch arguments. | ||
| # W0212 Access to a protected member %s of a client class | ||
| # W0232 Class has no __init__ method Used when a class has no __init__ method, neither its parent classes. | ||
| # W0613 Unused argument %r Used when a function or method argument is not used. | ||
| # W0702 No exception's type specified Used when an except clause doesn't specify exceptions type to catch. | ||
| # R0201 Method could be a function | ||
| # W0614 Unused import XYZ from wildcard import | ||
| # R0914 Too many local variables | ||
| # R0912 Too many branches | ||
| # R0915 Too many statements | ||
| # R0913 Too many arguments | ||
| # R0904 Too many public methods | ||
| # E0211: Method has no argument | ||
| # E1128: Assigning to function call which only returns None Used when an assignment is done on a function call but the inferred function returns nothing but None. | ||
| # E1129: Context manager ‘%s’ doesn’t implement __enter__ and __exit__. Used when an instance in a with statement doesn’t implement the context manager protocol(__enter__/__exit__). | ||
| disable=C0103,C0111,I0011,I0012,W0704,W0142,W0212,W0232,W0613,W0702,R0201,W0614,R0914,R0912,R0915,R0913,R0904,R0801,not-context-manager,assignment-from-none | ||
|
|
||
| [TYPECHECK] | ||
| # Note: This modules are manipulated during the runtime so we can't detect all the properties during | ||
| # static analysis | ||
| # The lib package is automatically added to PYTHONPATH by ST2 for Python actions | ||
| ignored-modules=distutils,eventlet.green.subprocess,six,six.moves,lib | ||
|
|
||
| [FORMAT] | ||
| max-line-length=100 | ||
| max-module-lines=1000 | ||
| indent-string=' ' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| [MESSAGES CONTROL] | ||
| # C0111 Missing docstring | ||
| # I0011 Warning locally suppressed using disable-msg | ||
| # I0012 Warning locally suppressed using disable-msg | ||
| # W0704 Except doesn't do anything Used when an except clause does nothing but "pass" and there is no "else" clause | ||
| # W0142 Used * or * magic* Used when a function or method is called using *args or **kwargs to dispatch arguments. | ||
| # W0212 Access to a protected member %s of a client class | ||
| # W0232 Class has no __init__ method Used when a class has no __init__ method, neither its parent classes. | ||
| # W0511 Used when a warning note as FIXME or XXX is detected. | ||
| # W0613 Unused argument %r Used when a function or method argument is not used. | ||
| # W0702 No exception's type specified Used when an except clause doesn't specify exceptions type to catch. | ||
| # R0201 Method could be a function | ||
| # W0614 Unused import XYZ from wildcard import | ||
| # W0621 Redefining name %r from outer scope (line %s) Used when a variable’s name hide a name defined in the outer scope. | ||
| # R0914 Too many local variables | ||
| # R0912 Too many branches | ||
| # R0915 Too many statements | ||
| # R0913 Too many arguments | ||
| # R0904 Too many public methods | ||
| # E0211: Method has no argument | ||
| # E1128: Assigning to function call which only returns None Used when an assignment is done on a function call but the inferred function returns nothing but None. | ||
| # E1129: Context manager ‘%s’ doesn’t implement __enter__ and __exit__. Used when an instance in a with statement doesn’t implement the context manager protocol(__enter__/__exit__). | ||
| disable=C0103,C0111,I0011,I0012,W0704,W0142,W0212,W0232,W0511,W0613,W0702,R0201,W0614,W0621,R0914,R0912,R0915,R0913,R0904,R0801,not-context-manager,assignment-from-none | ||
|
|
||
| [TYPECHECK] | ||
| # Note: This modules are manipulated during the runtime so we can't detect all the properties during | ||
| # static analysis | ||
| ignored-modules=distutils,eventlet.green.subprocess,six,six.moves,st2common | ||
|
|
||
| [FORMAT] | ||
| max-line-length=100 | ||
| max-module-lines=1000 | ||
| indent-string=' ' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| pysaml2>=4.8.0,<4.9.0 | ||
| pysaml2>=7.1.2,<7.2.0 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure this change is actually needed