Skip to content

Conversation

@mukunku
Copy link
Collaborator

@mukunku mukunku commented Sep 16, 2025

Summary

We got the same merge conflicts as last time during a release: #1981

Not sure if I didn't merge correctly or not so trying again in this PR.

mukunku and others added 16 commits August 7, 2025 08:06
* fix reported focus issue

* Also handle case where modal has no tabbable elements

* fix webpack.config.js for windows

* move if check up

* Create loud-suits-stare.md

* fix whitespace

* revert html changes

* revert harder

* add tests

* lint
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…trast dark mode (#1965)

* Correct readme

* Don't run minicssextractplugin when running locally

* Revert changes

* update border colour for dark mode and high contrast dark mode

* Create tasty-masks-pump.md

* Minor notice border style refactor

* Update visual regression test images

---------

Co-authored-by: Dan Cormier <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Bumps [webpack](https://github.com/webpack/webpack) from 5.99.9 to 5.101.2.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](webpack/webpack@v5.99.9...v5.101.2)

---
updated-dependencies:
- dependency-name: webpack
  dependency-version: 5.101.2
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
… into NPM workspaces (#1969)

* mention why we are doing this as part of project SHINE

* move folders

* update paths

* fix docs site and visual tests script

* fix a11y and unit test scripts and tweak visual regression threshold

* fix workflow tests

* revert ci import paths to fix tests

* try older image

* fix visual ci tests?

* mark stacks-docs not publishable

* adjust adr based on pr feedback

* adjust names

* address PR feedback

* add missing workspace param

* switch back to old script

* fix netlify and a11y

* fix path

* try fix workflows

* fix harder

* PR feedback

* pr feedback round 2

* move some more packages around

* Create eighty-pillows-relate.md
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 7.1.3 to 7.1.5.
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v7.1.5/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-version: 7.1.5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* add readme's for each package

* Create six-buckets-grab.md

* adjust stacks classic readme a bit
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@changeset-bot
Copy link

changeset-bot bot commented Sep 16, 2025

⚠️ No Changeset found

Latest commit: edc3d63

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Sep 16, 2025

Deploy Preview for stacks ready!

Name Link
🔨 Latest commit edc3d63
🔍 Latest deploy log https://app.netlify.com/projects/stacks/deploys/68c968a8deff70000834df8a
😎 Deploy Preview https://deploy-preview-1987--stacks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mukunku mukunku marked this pull request as ready for review September 16, 2025 13:48
@mukunku mukunku merged commit 5546882 into production Sep 16, 2025
5 checks passed
@mukunku mukunku deleted the sal/fix-merge-conflict-spark-12 branch September 16, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants