Skip to content

Conversation

@JEreth
Copy link
Contributor

@JEreth JEreth commented Feb 21, 2024

Thank you for your work. We were playing around with your plugin and had some issues at building it for Android. We were able to fix it by adding some missing parameters and dependencies in the build.gradle file. Maybe this helps someone who is stumbling over this plugin

@maximzhemerenko
Copy link
Contributor

Thank you very much for your effort and this pull request. I will check these changes on my environment and try to merge tomorrow.

It’s a great pleasure that my work will be helpful for another people!

@maximzhemerenko
Copy link
Contributor

Hi @JEreth,

I made some tests and propose the corrections, please check my changes using this gist https://gist.github.com/maximzhemerenko/6b3b799d819a5a0e941db4a59fc8a9b8

It contains the next changes:

  1. I replaced project.hasProperty to rootProject.hasProperty calls because previous implementation returned me wrong result.
  2. moved kotlinVersion to buildscript's ext section, because in buildscript section I cannot retrieve data from global ext section
  3. Renamed kotlinVersion to kotlin_version because I see this key name here https://github.com/ionic-team/capacitor/blob/main/android/capacitor/build.gradle

Could you please test changed gradle file in your project and if yes, change in this pull request and write me again? If after changes your app will compile I will merge this pull request

@JEreth
Copy link
Contributor Author

JEreth commented Feb 22, 2024

Thank you for checking @maximzhemerenko - worked like a charm.

@maximzhemerenko maximzhemerenko merged commit ae912d7 into SpryRocks:main Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants