Templating functions - setHeader, initArray, variadic concat #1201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommysitu
commented
Aug 21, 2025
stuioco
changed the title
tommysitu
commented
Aug 29, 2025
tommysitu
commented
Aug 29, 2025
| } else { | ||
| // @todo Maybe we can panic on that | ||
| return reflect.Zero(strType) | ||
| if funcType.IsVariadic() { |
Member
Author
There was a problem hiding this comment.
have we manually updated this file in vendor package?
Contributor
There was a problem hiding this comment.
Yes, in order to support variadic template helpers
Member
Author
There was a problem hiding this comment.
Do you get this code from the official Raymond library? If this is our own implementation, we need to update the fork: https://github.com/SpectoLabs/raymond and then bump the version in hoverfly go.mod.
Because vendor package is maintened by running go mod vendor and it will override any manual change.
tommysitu
commented
Sep 2, 2025
tommysitu
force-pushed
the
templating-header-manipulation
branch
from
ed80a9f to
f69e5ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.