JS-815 Use same WebSocket connection on each Sensor execution #5569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
zglicz
reviewed
Jul 23, 2025
Comment on lines
+255
to
+258
| if (client != null && client.isOpen()) { | ||
| LOG.debug("WebSocket connection already established"); | ||
| return; | ||
| } |
There was a problem hiding this comment.
Can we get to a case, like with dotnet, that they have concurrent calls to analyzeProject with different params? So that we actually have intertwining initLinter and actual analysis calls?
I think also you should be able to test this, no?
There was a problem hiding this comment.
in principle, there is no concurrency at all. All sensors and modules are executed serially. But just want to play safe here.
zglicz
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JS-815
Part of