Skip to content

JS-716 AST consumers should get all ASTs in PR analysis context #5402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
May 22, 2025
Merged

JS-716 AST consumers should get all ASTs in PR analysis context #5402

merged 11 commits into from
May 22, 2025

Conversation

karim-ouerghemmi-sonarsource
Copy link
Contributor

@karim-ouerghemmi-sonarsource karim-ouerghemmi-sonarsource commented May 21, 2025 •
edited by jira bot
Loading

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title JS716 AST consumers should get all ASTs in PR analysis context JS-732 JS716 AST consumers should get all ASTs in PR analysis context May 21, 2025
@karim-ouerghemmi-sonarsource karim-ouerghemmi-sonarsource changed the title JS-732 JS716 AST consumers should get all ASTs in PR analysis context JS-716 AST consumers should get all ASTs in PR analysis context May 21, 2025
karim-ouerghemmi-sonarsource
karim-ouerghemmi-sonarsource commented May 21, 2025
View reviewed changes
its/plugin/plugins/consumer-plugin/pom.xml
@@ -40,7 +40,7 @@
<configuration>
<pluginApiMinVersion>${pluginApiMinVersion}</pluginApiMinVersion>
<pluginClass>org.sonar.samples.javascript.consumer.ConsumerPlugin</pluginClass>
<requiredForLanguages>js</requiredForLanguages>
<requiredForLanguages>js,ts</requiredForLanguages>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added as I used this plugin in the IT that runs once with js and once with ts

@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
94.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@karim-ouerghemmi-sonarsource karim-ouerghemmi-sonarsource marked this pull request as ready for review May 21, 2025 14:35
vdiez
vdiez approved these changes May 22, 2025
View reviewed changes
Copy link
Contributor

@vdiez vdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@karim-ouerghemmi-sonarsource karim-ouerghemmi-sonarsource merged commit 1ec7c00 into master May 22, 2025
27 checks passed
@karim-ouerghemmi-sonarsource karim-ouerghemmi-sonarsource deleted the karim/JS-716 branch May 22, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdiez vdiez vdiez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karim-ouerghemmi-sonarsource @vdiez