JS-713 S2699 new implementation could cause endless loop #5365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashicorp-vault-sonar-prod
bot
changed the title
zglicz
commented
May 9, 2025
|
|
||
| it("uses chai 'should'", function() { // Noncompliant {{Add at least one assertion to this test case.}} | ||
| // The same is true for "should" assertions. | ||
| throwsTypeError.should.to.not.throw(ReferenceError) |
There was a problem hiding this comment.
this testcase would do an endless loop. Extracted from - https://github.com/SonarSource/expected-issues/blob/master/javascript/test/RSPEC_6092/uncertainAssertion.test.js#L43C5-L48C8
|
vdiez
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JS-713
Fuond based on peachee job - and failing on the last test-case here - https://github.com/SonarSource/expected-issues/blob/master/javascript/test/RSPEC_6092/uncertainAssertion.test.js
If we jump to 'ArrowExpression', we already know its a local variable and we don't need to extract the fqn.