Skip to content

JS-707 S2068 should be case-insensitive and support "passphrase" #5344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 2, 2025
Merged

JS-707 S2068 should be case-insensitive and support "passphrase" #5344

merged 3 commits into from
May 2, 2025

Conversation

GabinL21
Copy link
Contributor

@GabinL21 GabinL21 commented May 1, 2025 •
edited by jira bot
Loading

@GabinL21 GabinL21 self-assigned this May 1, 2025
@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title S2068 should be case-insensitive and support "passphrase" JS-707 S2068 should be case-insensitive and support "passphrase" May 1, 2025
vdiez
vdiez requested changes May 2, 2025
View reviewed changes
Copy link
Contributor

@vdiez vdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @GabinL21,

looks good! However I see a possible issue as the strings can be customize by the user, and he can pass uppercased strings. We should also lowercase the variableNames array I would say.

@GabinL21
Copy link
Contributor Author

GabinL21 commented May 2, 2025

Very fair point @vdiez, thanks! It should look better now 😄

@sonarqube-next SonarQube-Next
Copy link

sonarqube-next bot commented May 2, 2025

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@GabinL21 GabinL21 requested a review from vdiez May 2, 2025 08:54
vdiez
vdiez approved these changes May 2, 2025
View reviewed changes
Copy link
Contributor

@vdiez vdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you!

@vdiez vdiez merged commit 7cb10e2 into master May 2, 2025
22 checks passed
@vdiez vdiez deleted the gabin/improve-S2068-consistency branch May 2, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdiez vdiez vdiez approved these changes

Assignees

@GabinL21 GabinL21

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GabinL21 @vdiez