JS-72 JS-342 Calls to node:assert library should count as valid assertions #5320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zglicz
changed the title
zglicz
commented
Apr 23, 2025
| @@ -0,0 +1,16 @@ | |||
| import assert, { deepStrictEqual } from "assert"; | |||
| import vitest from 'vitest'; | |||
There was a problem hiding this comment.
This can be any import from the 4 frameworks that identify a file to be a test file.
| deepStrictEqual({ a: 1 }, { a: '1' }); | ||
| }); | ||
|
|
||
| it('should recognize issue', () => { // Noncompliant {{Add at least one assertion to this test case.}} |
There was a problem hiding this comment.
Necessary to have an issue that raises in each test
zglicz
changed the title
vdiez
reviewed
Apr 28, 2025
vdiez
approved these changes
Apr 28, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JS-41
This way, if a user is using the node built-in library 'assert', we will consider it a valid assertion.