JS-690 Update message on latest supported Typescript #5303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashicorp-vault-sonar-prod
bot
changed the title
|
zglicz
reviewed
Apr 16, 2025
|
I think we can do the same log catching the exception in the Node.js process and logging this same message. Not sure it's worthy overengineering the whole thing to have the semver string on the java side. This is just a fix to have this matching in the next release, but I would like to remove it completely from Java |
zglicz
approved these changes
Apr 16, 2025
|
no, it's not. just from a unit test. Ticket created: https://sonarsource.atlassian.net/browse/JS-692 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JS-690
This will happen again every time renovate updates TS version. We should get rid of this TS hardcoded version in Java side