JS-654 Don't use maven profile for ITS #5224
Conversation
hashicorp-vault-sonar-prod
bot
changed the title
vdiez
force-pushed
the
remove-its-profile
branch
3 times, most recently
from
0ae62f7 to
dac38f6
Compare
vdiez
force-pushed
the
remove-its-profile
branch
2 times, most recently
from
ae1ad4d to
ae76c65
Compare
|
| @@ -126,7 +126,7 @@ plugin_qa_body: &PLUGIN_QA_BODY | |||
| qa_script: | |||
| - source cirrus-env QA | |||
| - source set_maven_build_version $BUILD_NUMBER | |||
| - mvn -f its/plugin/pom.xml -Dsonar.runtimeVersion=${SQ_VERSION} ${MVN_TEST} -B -e -V verify surefire-report:report | |||
| - mvn -f its/plugin/pom.xml -DskipTests=false -Dsonar.runtimeVersion=${SQ_VERSION} ${MVN_TEST} -B -e -V verify surefire-report:report | |||
There was a problem hiding this comment.
hm... all of these tasks will depend on the build task and the build task will run the tests. I do not think we should run them again in each of the qa-body
There was a problem hiding this comment.
here we override the skipTests=true of the pom.xml, as in qa tasks we do want to run the tests
| @@ -56,5 +56,14 @@ | |||
| </plugin> | |||
| </plugins> | |||
| </build> | |||
| <properties> | |||
| <maven.deploy.skip>true</maven.deploy.skip> | |||
| <skipTests>true</skipTests> | |||
There was a problem hiding this comment.
hm... so you do skipTests, why say 'skipTests=false' above? I guess, in the CI, we know that we run after the build so the tests are always ran. But here, perhaps it's worthyto keep the unit-tests before the its run?
There was a problem hiding this comment.
we don't want to run the tests as they are actually ITS, we just want to compile the sources in the its folder
| <!-- sonar scanner properties --> | ||
| <sonar.sources>src/main</sonar.sources> | ||
| <sonar.tests>src/test</sonar.tests> | ||
| <sonar.javascript.lcov.reportPaths/> |
There was a problem hiding this comment.
why is this here? lcov is only produced based on the unit-test runs and these are completely unrelated
There was a problem hiding this comment.
otherwise it will inherit from parent pom
| <!-- | ||
| its module is added via profile below | ||
| --> | ||
| <module>its</module> |
There was a problem hiding this comment.
now learning of profiles, why move it in by default? Won't this cause all of our builds to have to go through these always? Otherwise, they were only invoked with mvn build -Pits
There was a problem hiding this comment.
by adding this here, it's taken when running the build task to compile sources, without depending on a profile
zglicz
force-pushed
the
remove-its-profile
branch
from
ae76c65 to
29926cb
Compare
|
JS-654