JS-652 Changing the dependency of meta and generated-meta #5217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashicorp-vault-sonar-prod
bot
changed the title
zglicz
commented
Mar 19, 2025
vdiez
approved these changes
Mar 19, 2025
There was a problem hiding this comment.
Looks good to me. some points:
- for me
npm ciis a prerequisite. we should have dependencies installed:- no need to run npx in scripts
- we can always prettify
- seems changes on the git submodules have been pushed. can you run
git submodules updatelocally? I don't think there have been changes on them lately so so may have an old commit locally. In any case, don't add them to this PR pls
ericmorand-sonarsource
approved these changes
Mar 19, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JS-652
As this was a bit out of order, we should not have hand written code depend on generated code. This way, we can access
meta.jsbefore thegenerated-meta.jsis presented.With these changes, I was able to remove the dependency of
javascript-checksonbridge. This way, the bridge starts building instantly when using the parallel option of maven build!