Skip to content

JS-548 Make parser and parserOptions visible in rules #5094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 4, 2025
Merged

Conversation

vdiez
Copy link
Contributor

@vdiez vdiez commented Feb 3, 2025

JS-548

We need to have the parser and parserOptions available to be able to implement ESLINTJS-60

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title Make parser and parserOptions visible in rules JS-548 Make parser and parserOptions visible in rules Feb 3, 2025
@vdiez vdiez requested a review from zglicz February 4, 2025 09:26
Copy link
Contributor

@zglicz zglicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just cosmetic comments from my side. 👌

@@ -81,7 +81,7 @@ function analyzeFile(linter: LinterWrapper, extendedSourceCodes: ExtendedSourceC

function analyzeSnippet(linter: LinterWrapper, extendedSourceCode: ExtendedSourceCode) {
const { issues, ucfgPaths } = linter.lint(
extendedSourceCode.sourceCode,
extendedSourceCode,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be also renamed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link

sonarqube-next bot commented Feb 4, 2025

@vdiez vdiez merged commit da0f473 into master Feb 4, 2025
17 of 18 checks passed
@vdiez vdiez deleted the visible-parser branch February 4, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants