Skip to content

Conversation

@daxpedda
Copy link
Contributor

@daxpedda daxpedda commented Jun 5, 2023

Apparently pub extern crate requires docs with the missing_docs lint and you can't use #[allow(...)] on it. So replacing it with pub use fixes this issue.

Also sprinkled some #[allow(clippy::redundant_clone)] until rust-lang/rust-clippy#10873 reaches stable.

@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8ab73a1) 73.58% compared to head (e1b2b80) 73.58%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #628   +/-   ##
=======================================
  Coverage   73.58%   73.58%           
=======================================
  Files          47       47           
  Lines        7637     7637           
=======================================
  Hits         5620     5620           
  Misses       2017     2017           
Flag Coverage Δ
main 58.98% <ø> (ø)
test-- 78.34% <ø> (ø)
test--server_system 61.63% <ø> (ø)
test-client_system- 69.36% <ø> (ø)
test-client_system-server_system 51.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@elinorbgr
Copy link
Member

I would prefer to keep them as pub extern crate, to make it explicit in the generated documentation that they are reexported crates.

So instead let's just going to put some basic documentation on them. Older rustc apparently just ignores it.

@elinorbgr
Copy link
Member

Actually it looks like even nightly rustdoc ignores documentation of pub extern crate items when generating the documentation. Not sure why this lint was enabled then. 🤷‍♀️

@daxpedda
Copy link
Contributor Author

daxpedda commented Jun 5, 2023

Actually it looks like even nightly rustdoc ignores documentation of pub extern crate items when generating the documentation. Not sure why this lint was enabled then. woman_shrugging

That is so weird ... on the brighter side of things: CI is fixed? 🤣

@elinorbgr
Copy link
Member

Yes, thanks!

@elinorbgr elinorbgr merged commit 9233b1e into Smithay:master Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants