FEND-670: Updating peer dependencies of eslint and eslint-plugin-react #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nayeemuddin-khan
changed the title
xres
reviewed
Jul 11, 2018
package.json
Outdated
| { | ||
| "name": "eslint-config-smartthings", | ||
| "version": "3.0.0", | ||
| "version": "3.3.0", |
There was a problem hiding this comment.
Why the jump from 3.0.0 to 3.3.0?
There was a problem hiding this comment.
I like to update to .3 . Want to revert it back for .1 ?
There was a problem hiding this comment.
Unless it's conflicting with published version, versioning should follow semver.
https://semver.org/
There was a problem hiding this comment.
I don't see any reason to jump by more than .1
There was a problem hiding this comment.
Changed to .1 fo version
xres
requested changes
Jul 12, 2018
|
@Dianoga could you help review? |
Dianoga
previously approved these changes
Jul 14, 2018
|
Looks good to me once the .DS_Store file is removed |
Issue solved for deprecated 'EcmaFeature'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue solved for deprecated 'EcmaFeature'