Implement mDNS discovery #478
Open
+231
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
How will it behave if there are more than 1 server on the network? |
Contributor
Author
|
@Eirenliel this currently queries A records, which are unique across a network, when the second server would attempt to register itself with the same hostname, it would fail and potentially rename itself. This can be used to detect instances of the server already running on the network, which could be used to implement SlimeVR/SlimeVR-Server#1581 In theory this could be solved by querying for SRV records instead, which can return all of them, but I didn't see the point, since we'd just use the first one that responds either way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements mDNS discovery. It searches for an mDNS record with host name "slimevr-server.local" and resolves it into the server's ip address. In some specific cases this should function better than broadcast based discovery.
mDNS packets are implemented manually to both make the process non-blocking and have it peacefully coexist with broadcast based discovery.