Add id command #438
Open
Add id command #438
+65
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eirenliel
requested changes
May 14, 2025
Eirenliel
approved these changes
May 14, 2025
Member
|
plz rebase 🥺 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #146
Adds an identification packet with id 28. This packet forces the LED on and doesn't let anything else turn it off until the server allows that. It also acknowledges this packet back to the server.
Probably a rework of the LED system to base it off priorities and whatnot would be in order to make this a bit cleaner.
The packet contains a sensorId, so it is in theory possible to idenfitify just an extension, but since this isn't currently supported in the code at all even if there were to be an LED on the extension, the param gets ignored and as a fallback the main LED gets lit up instead. Ideas are welcome.