Add restCalibrationStatus logic to the calibration tutorial #1574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gorbit99
requested review from
ButterscotchV,
Eirenliel,
Erimelowo and
loucass003
as code owners
github-actions
bot
added
Area: Application Protocol
Member
|
Conflitcts with #1407 this pr already gives validity check for restCalibration i think we should use the flag coming from the flightlist system instead of duplicating it in the protocol. Also there is debates about removing that page completely as it wont have a lot of impact during first setup |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on SlimeVR/SolarXR-Protocol#182
This PR implements the rest calibration status flag present in the SlimeVR firmware since version 0.5.4 into the server as well. Specifically the desk calibration tutorial now uses this flag if all of the trackers connected to the server support it. If that's not the case, the old behaviour is used as a fallback.
This flag could also be used down the line to warn the user in case their trackers haven't been calibrated yet, but this PR doesn't implement that behaviour.