Skip to content

Conversation

@antonfirsov
Copy link
Member

@antonfirsov antonfirsov commented May 5, 2019

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

// The non-generic Image.Load overloads no longer return Image<Rgba32>
using (Image image = Image.Load("foo.jpg"))
{
    image.Mutate(x => x.Resize(100, 100);
    image.SaveAsPng(someStream);
}
  • Touches Make ImageProcessor-s public #621 by making most of the non-generic processors public. (Exception: Histogram processors, because I'm not entirely happy with all namings.)
  • Fix a few doc issues while doing the refactor.
  • While implementing better test coverage for Image.Load variants, discovered and added a few missing overloads

Hope I haven't missed any of the important processors and / or extensions!

To enable extensions using color values as parameters on Image, we need to introduce a pixel-agnostic color type. I have a proposal for this, planning to PR it within the next week.

antonfirsov added 30 commits May 4, 2019 00:04
add suppression of SA1413 to AssemblyInfo.cs
@antonfirsov antonfirsov requested review from dlemstra and tocsoft May 9, 2019 21:54
@antonfirsov
Copy link
Member Author

Ok, went with the longer names. All processors without color parameters should be public (sealed) now.

@antonfirsov
Copy link
Member Author

I'm merging this to go on with the rest of #907. If I made a mistake, I will be able to fix it in the follow up PR-s.

@antonfirsov antonfirsov merged commit 25b3f75 into master May 10, 2019
@JimBobSquarePants JimBobSquarePants added this to the 1.0.0-rc1 milestone May 12, 2019
@JimBobSquarePants JimBobSquarePants deleted the af/non-generic-image-baseclass branch September 3, 2019 11:13
antonfirsov added a commit to antonfirsov/ImageSharp that referenced this pull request Nov 11, 2019
…baseclass

Introduce a non-generic Image base class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants