-
-
Notifications
You must be signed in to change notification settings - Fork 888
Fix travis builds #891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix travis builds #891
Conversation
|
@iamcarbon in #872, everything else seems C# 8 related to me. Am I missing something? |
|
Very odd. I thought #872 updated appveyor.yml to ensure the builds happen in VS2019. I'm not sure how it builds now while targeting C#8. |
Codecov Report
@@ Coverage Diff @@
## master #891 +/- ##
==========================================
+ Coverage 88.97% 88.98% +0.01%
==========================================
Files 1018 1018
Lines 44579 44537 -42
Branches 3234 3220 -14
==========================================
- Hits 39663 39632 -31
+ Misses 4195 4194 -1
+ Partials 721 711 -10
Continue to review full report at Codecov.
|
|
@JimBobSquarePants We only needed an SDK updated target C# 8.0 on AppVeyor. They updated the SDK in their standard image. |
Prerequisites
Description
Minimalistic subset of #872 to unblock our work.