Skip to content

Conversation

@iamcarbon
Copy link
Contributor

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

A few more things in colorspaces.

@iamcarbon
Copy link
Contributor Author

These stylecop errors don't always report locally. Annoying.

@codecov
Copy link

codecov bot commented Apr 12, 2019

Codecov Report

Merging #880 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #880   +/-   ##
=======================================
  Coverage   88.98%   88.98%           
=======================================
  Files        1017     1017           
  Lines       44464    44464           
  Branches     3228     3228           
=======================================
  Hits        39566    39566           
  Misses       4176     4176           
  Partials      722      722
Impacted Files Coverage Δ
...c/ImageSharp/ColorSpaces/Companding/LCompanding.cs 100% <ø> (ø) ⬆️
.../Implementation/WorkingSpaces/GammaWorkingSpace.cs 29.41% <ø> (ø) ⬆️
...eSharp/ColorSpaces/Companding/Rec2020Companding.cs 100% <ø> (ø) ⬆️
.../Implementation/Converters/YCbCrAndRgbConverter.cs 100% <ø> (ø) ⬆️
...eSharp/ColorSpaces/CieXyChromaticityCoordinates.cs 100% <ø> (ø) ⬆️
...lorSpaces/Conversion/ColorSpaceConverter.CieLch.cs 100% <ø> (ø) ⬆️
...n/Implementation/Converters/CmykAndRgbConverter.cs 100% <ø> (ø) ⬆️
...lementation/Converters/CieXyzAndCieXyyConverter.cs 100% <ø> (ø) ⬆️
...ageSharp/ColorSpaces/Companding/GammaCompanding.cs 100% <ø> (ø) ⬆️
...mentation/Converters/CieXyzToLinearRgbConverter.cs 80% <100%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dfa2f9...23b4a59. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 12, 2019

Codecov Report

Merging #880 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #880   +/-   ##
=======================================
  Coverage   88.98%   88.98%           
=======================================
  Files        1017     1017           
  Lines       44464    44464           
  Branches     3228     3228           
=======================================
  Hits        39566    39566           
  Misses       4176     4176           
  Partials      722      722
Impacted Files Coverage Δ
.../Implementation/WorkingSpaces/GammaWorkingSpace.cs 29.41% <ø> (ø) ⬆️
.../Implementation/Converters/YCbCrAndRgbConverter.cs 100% <ø> (ø) ⬆️
...eSharp/ColorSpaces/CieXyChromaticityCoordinates.cs 100% <ø> (ø) ⬆️
...lorSpaces/Conversion/ColorSpaceConverter.CieLch.cs 100% <ø> (ø) ⬆️
...n/Implementation/Converters/CmykAndRgbConverter.cs 100% <ø> (ø) ⬆️
...lementation/Converters/CieXyzAndCieXyyConverter.cs 100% <ø> (ø) ⬆️
...ageSharp/ColorSpaces/Companding/GammaCompanding.cs 100% <ø> (ø) ⬆️
...c/ImageSharp/ColorSpaces/Companding/LCompanding.cs 100% <100%> (ø) ⬆️
...mentation/Converters/CieXyzToLinearRgbConverter.cs 80% <100%> (ø) ⬆️
...eSharp/ColorSpaces/Companding/Rec2020Companding.cs 100% <100%> (ø) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48bac7b...dae4716. Read the comment docs.

@JimBobSquarePants
Copy link
Member

Just added some fixes I had planned to the companding algorithms. This was the perfect opportunity to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants