Skip to content

Conversation

@JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Fix #845

@codecov
Copy link

codecov bot commented Mar 15, 2019

Codecov Report

Merging #848 into master will decrease coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #848      +/-   ##
==========================================
- Coverage   88.88%   88.79%   -0.09%     
==========================================
  Files        1014     1014              
  Lines       44272    44289      +17     
  Branches     3206     3207       +1     
==========================================
- Hits        39349    39325      -24     
- Misses       4201     4203       +2     
- Partials      722      761      +39
Impacted Files Coverage Δ
tests/ImageSharp.Tests/TestImages.cs 100% <ø> (ø) ⬆️
...arp.Tests/Formats/Jpg/JpegDecoderTests.MetaData.cs 100% <ø> (ø) ⬆️
...rc/ImageSharp/Formats/Jpeg/Components/Block8x8F.cs 87.13% <100%> (+0.91%) ⬆️
...ormats/Jpeg/Components/Decoder/QualityEvaluator.cs 94.04% <100%> (+2.48%) ⬆️
...xelFormats/PixelOperations{TPixel}.PixelBenders.cs 89.34% <0%> (-9.84%) ⬇️
...Processing/Processors/Transforms/TransformUtils.cs 88.29% <0%> (-5.32%) ⬇️
src/ImageSharp/Common/Helpers/ImageMaths.cs 82.05% <0%> (-5.13%) ⬇️
.../Processing/Processors/Transforms/CropProcessor.cs 96% <0%> (-4%) ⬇️
...ocessing/Processors/Dithering/ErrorDiffuserBase.cs 93.75% <0%> (-3.13%) ⬇️
...rs/Normalization/HistogramEqualizationProcessor.cs 97.5% <0%> (-2.5%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 617c77c...1e7e992. Read the comment docs.

Copy link
Member

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@JimBobSquarePants JimBobSquarePants merged commit 6c637af into master Mar 15, 2019
@JimBobSquarePants JimBobSquarePants deleted the js/fix-845 branch March 16, 2019 00:52
antonfirsov pushed a commit to antonfirsov/ImageSharp that referenced this pull request Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants