better FillSolidBrushTests + bugfix in FillProcessor #555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tocsoft
approved these changes
May 1, 2018
antonfirsov
added a commit
to antonfirsov/ImageSharp
that referenced
this pull request
Nov 11, 2019
better FillSolidBrushTests + bugfix in FillProcessor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
I just realized that
FillProcessorandFillRegionProcessorare two different things, so the tests in #553 do not coverFillProcessorthus are insufficient to safely merge #552.This PR:
SolidBrushscenarios/parametersFillProcessor: unlike inFillRegionProcessor,BlendPercentagewas applied two times: once inFillProcessor, once inSolidBrushApplicator. The easiest way to see this is to undo the change and runBlendFillColorOverBackround.