Skip to content

Don't skip reading data for animation chunks on identify. #2674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 26, 2024
Merged

Don't skip reading data for animation chunks on identify. #2674

merged 3 commits into from
Feb 26, 2024

Conversation

@JimBobSquarePants
Copy link
Member

@JimBobSquarePants JimBobSquarePants commented Feb 23, 2024 •
edited
Loading

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Fixes #2666

Will follow up fix in main following merge.

@JimBobSquarePants JimBobSquarePants merged commit 9c9854d into release/3.1.x Feb 26, 2024
@JimBobSquarePants JimBobSquarePants deleted the js/fix-2666 branch February 26, 2024 00:44
@JimBobSquarePants JimBobSquarePants mentioned this pull request Feb 26, 2024
Merged
4 tasks
JimBobSquarePants added a commit that referenced this pull request Feb 26, 2024
@JimBobSquarePants
Merge pull request #2675 from SixLabors/js/v3-fixes
f85500d 
Add v3.1.x fixes #2673 and #2674 into main.
@JimBobSquarePants JimBobSquarePants mentioned this pull request Mar 16, 2024
Closed
4 tasks
This was referenced Jul 30, 2025
Open
Open
Open
Open
This was referenced Sep 24, 2025
Merged
Closed
@dependabot dependabot bot mentioned this pull request Oct 6, 2025
Closed
@dependabot dependabot bot mentioned this pull request Oct 13, 2025
Open
@dependabot dependabot bot mentioned this pull request Oct 26, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tocsoft tocsoft tocsoft approved these changes

@antonfirsov antonfirsov Awaiting requested review from antonfirsov

@dlemstra dlemstra Awaiting requested review from dlemstra

@brianpopow brianpopow Awaiting requested review from brianpopow

Assignees

No one assigned

Labels

bug formats:png

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JimBobSquarePants @tocsoft