Skip to content

Replace custom Crc32 #2611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 9, 2023
Merged

Replace custom Crc32 #2611

merged 2 commits into from
Dec 9, 2023

Conversation

@JimBobSquarePants
Copy link
Member

@JimBobSquarePants JimBobSquarePants commented Dec 9, 2023

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Removes our custom Crc32 implementation in favor of the runtime one which benchmarks slightly faster.
Also fixes the benchmark configuration so that they work for .NET8.

@JimBobSquarePants JimBobSquarePants added this to the v4.0.0 milestone Dec 9, 2023
@JimBobSquarePants JimBobSquarePants merged commit 66b6eb9 into main Dec 9, 2023
@JimBobSquarePants JimBobSquarePants deleted the js/runtime-crc32 branch December 9, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tocsoft tocsoft tocsoft approved these changes

@brianpopow brianpopow Awaiting requested review from brianpopow

@antonfirsov antonfirsov Awaiting requested review from antonfirsov

@dlemstra dlemstra Awaiting requested review from dlemstra

Assignees

No one assigned

Labels

area:performance formats:png

Projects

None yet

Milestone

v4.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@JimBobSquarePants @tocsoft