Skip to content

V2 Backport: 2133, 2154 #2157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 18, 2022
Merged

V2 Backport: 2133, 2154 #2157

merged 2 commits into from
Jun 18, 2022

Conversation

@JimBobSquarePants
Copy link
Member

@JimBobSquarePants JimBobSquarePants commented Jun 17, 2022

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Adds backported fixes for #2133 and #2154

@JimBobSquarePants JimBobSquarePants changed the title Backport: 2133, 2154 V2 Backport: 2133, 2154 Jun 17, 2022
brianpopow
brianpopow approved these changes Jun 17, 2022
View reviewed changes
Copy link
Collaborator

@brianpopow brianpopow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@JimBobSquarePants JimBobSquarePants merged commit f53c78d into release/2.1.x Jun 18, 2022
@JimBobSquarePants JimBobSquarePants deleted the backport/2135-2154 branch June 18, 2022 00:14
This was referenced Jul 23, 2025
Closed
Merged
Merged
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Closed
Closed
Open
Open
Open
This was referenced Jul 30, 2025
Open
Open
Open
Open
Open
This was referenced Sep 23, 2025
Open
Open
This was referenced Oct 3, 2025
Open
Merged
Closed
Open
This was referenced Oct 19, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brianpopow brianpopow brianpopow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JimBobSquarePants @brianpopow