-
-
Notifications
You must be signed in to change notification settings - Fork 887
Deduce color space as YCbCr if component id's are 1, 2, 3 #2135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
br3aker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Image from the issue is neither jfif nor adobe jfif, it was encoded with app1 marker which we indeed ignored during color deduction. I didn't find any information regarding jpeg encoding color type from exif specs so component id color deduction seems to be a solution.
@br3aker thanks for your feedback! |
antonfirsov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Do you think we should backport this since we introduced the issue in the last patch? |
I would not consider this a critical issue, it's more an edge case, so I don't think we need to backport this. |
Prerequisites
Description
Another case of deducing the color space of a jpeg image based on the component id's.
Related issue #2133