Skip to content

Conversation

@JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

See #1886 (comment)

Almost no actual code changes on the back of this but exposes a ton of new APIs to us.

@JimBobSquarePants JimBobSquarePants added area:build breaking Signifies a binary breaking change. labels Dec 12, 2021
@JimBobSquarePants JimBobSquarePants added this to the 2.0.0 milestone Dec 12, 2021
@JimBobSquarePants JimBobSquarePants requested a review from a team December 12, 2021 15:01
@brianpopow
Copy link
Collaborator

There is still a #if NETSTANDARD1_3 in Guard.cs leftover

@codecov
Copy link

codecov bot commented Dec 12, 2021

Codecov Report

Merging #1888 (436b8a0) into master (ae7b995) will decrease coverage by 0%.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1888   +/-   ##
======================================
- Coverage      87%     87%   -1%     
======================================
  Files         957     957           
  Lines       50393   50389    -4     
  Branches     6263    6263           
======================================
- Hits        44180   44176    -4     
  Misses       5181    5181           
  Partials     1032    1032           
Flag Coverage Δ
unittests 87% <0%> (-1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/ImageSharp/Common/Helpers/Guard.cs 25% <0%> (-38%) ⬇️
.../Tiff/Compression/Compressors/DeflateCompressor.cs 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae7b995...436b8a0. Read the comment docs.

@JimBobSquarePants
Copy link
Member Author

JimBobSquarePants commented Dec 12, 2021

That’s loaded via the submodule no? I’ll double check.

EDIT.

Found it and removed. Good catch!

@JimBobSquarePants JimBobSquarePants merged commit 53456a5 into master Dec 13, 2021
@JimBobSquarePants JimBobSquarePants deleted the js/drop-ns-1-3 branch December 13, 2021 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:build breaking Signifies a binary breaking change.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants