-
-
Notifications
You must be signed in to change notification settings - Fork 888
Added missing CancellationToken parameters to Image #1856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1856 +/- ##
======================================
Coverage 87% 87%
======================================
Files 937 937
Lines 48727 48727
Branches 6094 6094
======================================
Hits 42507 42507
Misses 5209 5209
Partials 1011 1011
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
This is fantastic @justinbhopper Thanks! |
Prerequisites
Description
I noticed that a few asynchronous overloaded methods on the Image class were needlessly omitting a CancellationToken parameter when the underlying code supported cancellation. This PR adds the cancel token parameter, but keeps them optional for backwards compatibility.