Skip to content

Conversation

@maxvoxel8
Copy link
Contributor

@maxvoxel8 maxvoxel8 commented Dec 6, 2020

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Use scaled vectors in FilterProcessor to fix #1459.

@codecov
Copy link

codecov bot commented Dec 6, 2020

Codecov Report

Merging #1463 (a311a16) into master (5ab768c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1463   +/-   ##
=======================================
  Coverage   83.66%   83.66%           
=======================================
  Files         736      736           
  Lines       32012    32012           
  Branches     3609     3609           
=======================================
  Hits        26782    26782           
  Misses       4516     4516           
  Partials      714      714           
Flag Coverage Δ
unittests 83.66% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...sing/Processors/Filters/FilterProcessor{TPixel}.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ab768c...a311a16. Read the comment docs.

@maxvoxel8 maxvoxel8 marked this pull request as ready for review December 7, 2020 17:15
Copy link
Member

@JimBobSquarePants JimBobSquarePants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks so much!

@JimBobSquarePants JimBobSquarePants merged commit 4bda224 into SixLabors:master Dec 7, 2020
JimBobSquarePants added a commit that referenced this pull request Mar 13, 2021
Filter processor should use scaled vectors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BrightnessProcessor incorrectly scales HalfSingle values.

2 participants