Skip to content

Add cache for Nuget packages #1439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 29, 2020
Merged

Add cache for Nuget packages #1439

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fed7d7b
Add cache for Nuget packages
AlexNDRmac Nov 24, 2020
55e38ab
Add props and targets to hash for cache key
AlexNDRmac Nov 24, 2020
2652977
Fix file pattern for hashFiles
AlexNDRmac Nov 24, 2020
30e4c90
Merge branch 'master' into ci-cache-action
antonfirsov Nov 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/build-and-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,14 @@ jobs:
git fetch --prune --unshallow
git submodule -q update --init --recursive

- name: Setup nuget cache
uses: actions/cache@v2
id: nuget-cache
with:
path: ~/.nuget
key: ${{ runner.os }}-nuget-${{ hashFiles('**/ImageSharp*.csproj') }}
Copy link
Member

@tocsoft tocsoft Nov 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you will need to add the *.props/*.targets too as we define most of our package versions in those shared locations i.e.

ImageSharp/Directory.Build.targets

Lines 19 to 37 in 0e0dc2a

<ItemGroup>
<!--Global Dependencies-->
<PackageReference Update="Microsoft.Net.Compilers.Toolset" PrivateAssets="All" Version="3.7.0" />
<PackageReference Update="Microsoft.NETFramework.ReferenceAssemblies" PrivateAssets="All" Version="1.0.0" />
<PackageReference Update="StyleCop.Analyzers" PrivateAssets="All" Version="1.1.118" />
<!--Src Dependencies-->
<PackageReference Update="Microsoft.SourceLink.GitHub" Version="1.0.0" PrivateAssets="All"/>
<PackageReference Update="MinVer" PrivateAssets="All" Version="2.3.1" />
<PackageReference Update="System.Buffers" Version="4.5.1" />
<PackageReference Update="System.IO.Compression" Version="4.3.0" />
<PackageReference Update="System.IO.UnmanagedMemoryStream" Version="4.3.0" />
<PackageReference Update="System.Numerics.Vectors" Version="4.5.0" />
<PackageReference Update="System.Memory" Version="4.5.4" />
<PackageReference Update="System.Runtime.CompilerServices.Unsafe" Version="4.7.1" />
<PackageReference Update="System.Threading.Tasks.Parallel" Version="4.3.0" />
<PackageReference Update="System.ValueTuple" Version="4.5.0" />
</ItemGroup>

Copy link
Contributor Author

@AlexNDRmac AlexNDRmac Nov 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Added with next commit.

restore-keys: ${{ runner.os }}-nuget-

- name: Build
shell: pwsh
run: ./ci-build.ps1 "${{matrix.options.framework}}"
Expand Down