-
-
Notifications
You must be signed in to change notification settings - Fork 889
Add "macos-latest" to build matrix #1302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
JimBobSquarePants
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
|
How can we add this to the list of Required checks? |
|
In the branch protection settings. You should have access but if not, I’ll do it Looks like we’re missing libgdiplus on the Mac OS. No idea how to add it |
|
There are many tests failing because of over-threshold differences in the output, two resize tests reporting 18% and 25% difference which may indicate an actual bug. |
could this do the trick? |
|
@brianpopow the condition did not evaluate to |
@antonfirsov i cannot spot why that is, looks correct. edit: maybe try |
|
Looks like it has been moved to |
|
29 test failures:
|
|
The padded resize bugs are interesting. Not sure how that happens... Transforms I’ll never be 100% happy with, could be the perfectionist in me but the edges never looked quite right to me. Not as crisp as imagemagick. I’ll see if I can jump on my wife’s Mac and check the output to see if any are worth investigating |
|
Doesn't make sense to keep around a stale PR, closing this in favor of #1387. |
Prerequisites
Description
Just noticed there is an available virtual environment for macOS. I think we should add it to the list of CI builds.