Skip to content

Swap buffers when encoding PNG with Filtered Adam7 Palette mode #1212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 6, 2020
Merged

Swap buffers when encoding PNG with Filtered Adam7 Palette mode #1212

merged 2 commits into from
Jun 6, 2020

Conversation

@JimBobSquarePants
Copy link
Member

@JimBobSquarePants JimBobSquarePants commented Jun 5, 2020

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

We weren't swapping the scanline buffers after collecting the filtered pixel in palette mode so certain filters were failing to encode correctly.

Fixes #1211

@JimBobSquarePants JimBobSquarePants added this to the 1.0.0 milestone Jun 5, 2020
@JimBobSquarePants JimBobSquarePants mentioned this pull request Jun 5, 2020
Closed
4 tasks
@JimBobSquarePants JimBobSquarePants requested a review from a team June 6, 2020 11:07
tocsoft
tocsoft approved these changes Jun 6, 2020
View reviewed changes
Copy link
Member

@tocsoft tocsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JimBobSquarePants JimBobSquarePants merged commit 225f1f8 into master Jun 6, 2020
@JimBobSquarePants JimBobSquarePants deleted the js/fix-1211 branch June 6, 2020 11:47
This was referenced Jul 30, 2025
Merged
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@dependabot dependabot bot mentioned this pull request Sep 23, 2025
Open
This was referenced Oct 3, 2025
Open
Merged
Closed
Open
@dependabot dependabot bot mentioned this pull request Oct 19, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tocsoft tocsoft tocsoft approved these changes

Assignees

No one assigned

Labels

bug formats:png

Projects

None yet

Milestone

1.0.0

Development

Successfully merging this pull request may close these issues.

Re-saving interlaced PNG results in corrupt image

3 participants

@JimBobSquarePants @tocsoft