Skip to content

Conversation

@brianpopow
Copy link
Collaborator

  • If all color map spec bytes are zero when color map type is zero
  • Width and height are not zero

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

The heuristic for detecting a TGA file now additionally checks:

  • If all color map spec bytes are zero when color map type is zero.
  • Width and height are not zero.

- If all color map spec bytes are zero when color map type is zero
- Width and height are not zero
@brianpopow brianpopow linked an issue May 27, 2020 that may be closed by this pull request
4 tasks
Copy link
Member

@JimBobSquarePants JimBobSquarePants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely!

@JimBobSquarePants JimBobSquarePants merged commit dbb3e43 into master May 27, 2020
@JimBobSquarePants JimBobSquarePants deleted the bp/detectTga branch May 27, 2020 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TGA format conflict with J2K format

3 participants