Skip to content

Conversation

@JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Updates struct name, method, and any comment references to match.

Copy link
Member

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@codecov
Copy link

codecov bot commented Apr 30, 2020

Codecov Report

Merging #1194 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1194   +/-   ##
=======================================
  Coverage   82.58%   82.58%           
=======================================
  Files         694      694           
  Lines       30046    30046           
  Branches     3397     3397           
=======================================
  Hits        24813    24813           
  Misses       4535     4535           
  Partials      698      698           
Flag Coverage Δ
#unittests 82.58% <100.00%> (ø)
Impacted Files Coverage Δ
.../Formats/Jpeg/Components/Block8x8F.ScaledCopyTo.cs 100.00% <ø> (ø)
...ssors/Quantization/DefaultPixelSamplingStrategy.cs 100.00% <ø> (ø)
...ors/Quantization/ExtensivePixelSamplingStrategy.cs 66.66% <ø> (ø)
...Processors/Quantization/OctreeQuantizer{TPixel}.cs 95.97% <ø> (ø)
...rocessors/Quantization/PaletteQuantizer{TPixel}.cs 100.00% <ø> (ø)
...ing/Processors/Quantization/WuQuantizer{TPixel}.cs 91.42% <ø> (ø)
src/ImageSharp/Formats/Gif/GifDecoderCore.cs 83.89% <100.00%> (ø)
src/ImageSharp/Memory/Buffer2DExtensions.cs 73.07% <100.00%> (ø)
src/ImageSharp/Memory/Buffer2DRegion{T}.cs 100.00% <100.00%> (ø)
...sing/Processors/Quantization/QuantizerUtilities.cs 96.15% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c6f0dc...bedd0a9. Read the comment docs.

@JimBobSquarePants JimBobSquarePants merged commit 1ac4042 into master Apr 30, 2020
@JimBobSquarePants JimBobSquarePants deleted the js-buffer2dregion branch April 30, 2020 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants