Skip to content

Conversation

@JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

We were previously using an int which was nasty. This PR introduces a new PngCompressionLevel which constrains this property properly.

Copy link
Collaborator

@brianpopow brianpopow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@codecov
Copy link

codecov bot commented Apr 29, 2020

Codecov Report

Merging #1192 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1192   +/-   ##
=======================================
  Coverage   82.54%   82.55%           
=======================================
  Files         692      692           
  Lines       29988    29989    +1     
  Branches     3389     3389           
=======================================
+ Hits        24755    24756    +1     
  Misses       4536     4536           
  Partials      697      697           
Flag Coverage Δ
#unittests 82.55% <100.00%> (+<0.01%) ⬆️
Impacted Files Coverage Δ
src/ImageSharp/Formats/Png/PngEncoder.cs 84.61% <100.00%> (ø)
src/ImageSharp/Formats/Png/PngEncoderOptions.cs 95.45% <100.00%> (ø)
...c/ImageSharp/Formats/Png/Zlib/ZlibDeflateStream.cs 69.56% <100.00%> (+0.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e790f94...a651570. Read the comment docs.

@JimBobSquarePants JimBobSquarePants merged commit ddbd624 into master Apr 29, 2020
@JimBobSquarePants JimBobSquarePants deleted the js/png-compression-options branch April 29, 2020 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants