Skip to content

Generic Octet<T> struct #1131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 27, 2020
Merged

Generic Octet<T> struct #1131

merged 3 commits into from
Feb 27, 2020

Conversation

@Sergio0694
Copy link
Member

@Sergio0694 Sergio0694 commented Feb 27, 2020

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

This PR introduces a new generic Octet<T> type to reduce code duplication.
This PR introduces a new generic Octet<T> type to reduce code duplication.

@Sergio0694 Sergio0694 added this to the 1.0.0 milestone Feb 27, 2020
@Sergio0694 Sergio0694 self-assigned this Feb 27, 2020
antonfirsov
antonfirsov approved these changes Feb 27, 2020
View reviewed changes
Copy link
Member

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@JimBobSquarePants JimBobSquarePants merged commit 71e3ac1 into master Feb 27, 2020
@JimBobSquarePants JimBobSquarePants deleted the sp/generic-octet branch February 27, 2020 04:38
@JimBobSquarePants JimBobSquarePants modified the milestones: 1.0.0, 1.0.0-rc1 Apr 24, 2020
This was referenced Jul 30, 2025
Merged
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@dependabot dependabot bot mentioned this pull request Sep 23, 2025
Open
This was referenced Oct 3, 2025
Open
Merged
Closed
Open
@dependabot dependabot bot mentioned this pull request Oct 19, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonfirsov antonfirsov antonfirsov approved these changes

Assignees

@Sergio0694 Sergio0694

Labels

API codequality

Projects

None yet

Milestone

1.0.0-rc1

Development

Successfully merging this pull request may close these issues.

4 participants

@Sergio0694 @antonfirsov @JimBobSquarePants