-
-
Notifications
You must be signed in to change notification settings - Fork 888
Bokeh blur cache optimization #1113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1113 +/- ##
==========================================
+ Coverage 82% 82.02% +0.01%
==========================================
Files 700 701 +1
Lines 28797 28797
Branches 3281 3281
==========================================
+ Hits 23616 23621 +5
+ Misses 4498 4494 -4
+ Partials 683 682 -1
Continue to review full report at Codecov.
|
JimBobSquarePants
approved these changes
Feb 18, 2020
This was referenced Jul 30, 2025
This was referenced Oct 3, 2025
This was referenced Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
The previous implementation of the
BokehBlurProcessor<TPixel>was using astatic ConcurrentDictionary<BokehBlurParameters, BokehBlurKernelData>field to store the preprocessed bokeh blur kernels for a pair of input parameters. The issue was that that static field was inside a generic class, meaning each concrete<TPixel>instantiation would've seen a completely different dictionary. As a result, running the same bokeh blur effect on multiple images of different pixel formats, even with the same parameters, would've caused the kernels to be recomputed every time, and stored separately in each dictionary, despite the kernels actually being exactly the same (they're not dependent on the pixel type they'll be used on).This PR moves all the kernel preprocessing logic into a separate non-generic class, to solve the issues described above. I've also removed some unnecessary fields from the
BokehBlurProcessor<TPixel>class, so that should also save a few bytes every time a new processor instance is created. 🚀